On Sat, Aug 6, 2022 at 12:03 PM Andres Freund <andres@anarazel.de> wrote:
> HAVE_GETTIMEOFDAY currently is only defined for mingw as the configure test is
> gated to windows - that's somewhat weird imo. mingw has had it since at least
> 2007. The attached patch makes the gettimeofday() fallback specific to msvc.
+1
> I've renamed the file to win32gettimeofday now. I wonder if we should rename
> files that are specific to msvc to indicate that? But that's for later.
+1, I was thinking the same.
> 1-arg gettimeofday() hasn't been around in a *long* while from what I can
> see. So I've removed that configure test.
+1
LGTM.