On Thu, Aug 4, 2022 at 2:04 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> I noticed that this says:
>
> [01:01:45.657] sqlda.pgc: In function 'dump_sqlda':
> [01:01:45.657] sqlda.pgc:45:33: warning: format '%d' expects argument
> of type 'int', but argument 3 has type 'long long int' [-Wformat=]
> [01:01:45.657] 45 | "name sqlda descriptor: '%s' value %I64d\n",
> [01:01:45.657] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [01:01:45.657] ......
> [01:01:45.657] 49 | sqlda->sqlvar[i].sqlname.data, *(long long int
> *)sqlda->sqlvar[i].sqldata);
> [01:01:45.657] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [01:01:45.657] | |
> [01:01:45.657] | long long int
>
> ... but fairywren doesn't. Why would they disagree on recognising %I64d?
Oops, I was looking in the wrong place. fairywren does also shows the warning:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=fairywren&dt=2022-08-02%2022%3A05%3A30&stg=ecpg-check
Something to fix, but not directly relevant to this patch. Sorry for the noise.