On Fri, 8 May 2020 at 13:36, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, May 7, 2020 at 4:02 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Thu, May 7, 2020 at 2:53 PM Masahiko Sawada
> > <masahiko.sawada@2ndquadrant.com> wrote:
> > >
> > > >
> > > > There is a typo in the patch (queris/queries). How about if slightly
> > > > reword it as "Since buffer manager locks are not taken to copy the
> > > > buffer state data that the view will display, accessing
> > > > <structname>pg_buffercache</structname> view has less impact on normal
> > > > buffer activity but it doesn't provide a consistent set of results
> > > > across all buffers. However, we ensure that the information of each
> > > > buffer is self-consistent."?
> > >
> > > Thank you for your idea. Agreed.
> > >
> > > Attached the updated version patch.
> > >
> >
> > LGTM. I will commit this tomorrow unless there are more comments.
> >
>
> Pushed.
>
Thank you!
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services