Re: patch: ALTER TABLE IF EXISTS

Поиск
Список
Период
Сортировка
От Simon Riggs
Тема Re: patch: ALTER TABLE IF EXISTS
Дата
Msg-id CA+U5nMLm5Opu8tK6v2CG1eb=NRicrGeK1Ah7wD3Z5twjWchibA@mail.gmail.com
обсуждение исходный текст
Ответ на patch: ALTER TABLE IF EXISTS  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: patch: ALTER TABLE IF EXISTS
Список pgsql-hackers
On Mon, Jan 2, 2012 at 1:11 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:

> this is relative simple patch that add possibility to skip noexisting
> tables. It is necessary for silent cleaning when dump is loaded.

Agreed, nice simple and uncontentious patch.

All good apart from two minor things:

* doc page needs to explain what IF EXISTS does, like DROP TABLE, e.g.

IF EXISTS   Do not throw an error if the table does not exist. A notice is
issued in this case.

* the error message is "does not exist" rather than "does not exists",
which means the code, a comment and a test need changing

Other than that, happy to apply as soon as you make those changes.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: patch: ALTER TABLE IF EXISTS
Следующее
От: "Tomas Vondra"
Дата:
Сообщение: Re: patch: ALTER TABLE IF EXISTS