Re: Comments on Custom RMGRs

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Comments on Custom RMGRs
Дата
Msg-id CA+TgmobB+AtAQKbEVWxPd=Q9da8_nQyRMEdya9Rr4Z=e1Wkrng@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Comments on Custom RMGRs  (Simon Riggs <simon.riggs@enterprisedb.com>)
Список pgsql-hackers
On Fri, May 13, 2022 at 8:47 AM Simon Riggs
<simon.riggs@enterprisedb.com> wrote:
> > Note that I'm *not* against making checkpoint extensible - I just think it
> > needs a good bit of design work around when the hook is called etc.
>
> When was any such work done previously for any other hook?? That isn't needed.

I think almost every proposal to add a hook results in some discussion
about how usable the hook will be and whether it's being put in the
correct place and called with the correct arguments.

I think that's a good thing, too. Otherwise the code would be
cluttered with a bunch of hooks that seemed to someone like a good
idea at the time but are actually just a maintenance headache.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Should use MERGE use BulkInsertState ?
Следующее
От: Andres Freund
Дата:
Сообщение: Re: recovery test failure on morepork with timestamp mystery