Re: dropping datumSort field

On Mon, Aug 8, 2022 at 5:51 PM Zhihong Yu <zyu@yugabyte.com> wrote:
> Hi,
> I was looking at ExecSort() w.r.t. datum sort.
>
> I wonder if the datumSort field can be dropped.
> Here is a patch illustrating the potential simplification.
>
> Please take a look.

One problem with this patch is that, if I apply it, PostgreSQL does not compile:

nodeSort.c:197:6: error: use of undeclared identifier 'tupDesc'
        if (tupDesc->natts == 1)
            ^
1 error generated.

Leaving that aside, I don't really see any advantage in this sort of change.

-- 
Robert Haas
EDB: http://www.enterprisedb.com