Re: [PATCH] Refactoring of LWLock tranches

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: [PATCH] Refactoring of LWLock tranches
Дата
Msg-id CA+TgmoZOsRY6nHbAbS7KeXymEffNSktLx3pemBO+syMLsW5OXQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Refactoring of LWLock tranches  (Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>)
Ответы Re: [PATCH] Refactoring of LWLock tranches  (Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>)
Список pgsql-hackers
On Mon, Nov 16, 2015 at 7:32 AM, Ildus Kurbangaliev
<i.kurbangaliev@postgrespro.ru> wrote:
> What if just create a control struct in shared memory like in other places? BufferDescriptors
> and BufferBlocks can be kept there along with tranches definitions
> and lwlocks. Buffer locks that are located in MainLWLockArray by offset
> can be moved there too.

Yeah, we could do that, but what's the advantage of it?  The alignment
of the buffer descriptors is kinda finnicky and matters to
performance, so it seems better not to prefix them with something that
might perturb it.  If we just rebase Andres' patch over what I just
committed and add in something so that the buffer numbers are fed from
#defines or an enum instead of being random integers, I think we're
done.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [PATCH] Refactoring of LWLock tranches
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Proposing COPY .. WITH PERMISSIVE