Re: [pgAdmin4] [Patch]: Language Module

Поиск

Список

Период

Сортировка

От	Dave Page
Тема	Re: [pgAdmin4] [Patch]: Language Module
Дата	12 февраля 2016 г. 19:34:31
Msg-id	CA+OCxowNGRLM+uPzOTMVBVpLbbRNQU+A8eDz668ioVMi0x4vCQ@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [pgAdmin4] [Patch]: Language Module (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Ответы	Re: [pgAdmin4] [Patch]: Language Module (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список	pgadmin-hackers

On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

New language patch is working fine.
Ashesh - Can you please review it ?
If it looks good then can you please commit ?

Thank you,
Harshal

A few comments:

- We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't we also therefore omit DROP LANGUAGE?

- Please leave a blank line between the file header and python code in python files.

- The pydoc module description is missing from __init__.py

- What about the Dependents and Dependencies tabs?

- There are few, if any comments in the Javascript. There should be at least minimal comments there to note the purpose of each logical code block.

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

От: Dave Page
Дата: 12 февраля 2016 г., 19:24:57
Сообщение: Re: patch for cast module

От: Dave Page
Дата: 12 февраля 2016 г., 19:40:43
Сообщение: pgAdmin 4 commit: Don't add (GROUP) to the end of group role names; tha