On Fri, Feb 14, 2020 at 2:58 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, Feb 14, 2020 at 1:04 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I've been burnt by this too :-(. However, I think this patch is
> > completely the wrong way to go about improving this. What we should
> > be doing, now that we have all that perl code generating postgres.bki,
> > is eliminating the problem at the source. That is, drop the hand-coded
> > relnatts values from pg_class.dat altogether, and let the perl code fill
> > it in --- compare the handling of pg_proc.pronargs for instance.
>
> I can't write Perl myself (maybe Justin), but +1 to this idea.
I tried and think it works but not sure if that's good Perl
programming. See the attached.
Thanks,
Amit