Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)

> On 17 Feb 2022, at 13:19, Ranier Vilela  wrote:

> 1. One #ifdef with a mistake, the correct is _WIN32 and not WIN32.

Can you elaborate on this, we are using WIN32 pretty extensively in the code:

 $ git grep "if[n]\{0,1\}def WIN32$"|wc -l
     511
 $ git grep "if[n]\{0,1\}def _WIN32$"|wc -l
       2

The _WIN32 cases are in the same ECPG testcase.

Why would _WIN32 be correct in this case?

--
Daniel Gustafsson		https://vmware.com/