Re: Patch for ALTER DATABASE WITH TABLESPACE

Поиск
Список
Период
Сортировка
От Bernd Helmle
Тема Re: Patch for ALTER DATABASE WITH TABLESPACE
Дата
Msg-id BFA2800A5DD0D2E0DFB25242@imhotep.credativ.de
обсуждение исходный текст
Ответ на Patch for ALTER DATABASE WITH TABLESPACE  (Guillaume Lelarge <guillaume@lelarge.info>)
Ответы Re: Patch for ALTER DATABASE WITH TABLESPACE
Список pgsql-hackers
--On Donnerstag, November 06, 2008 11:35:54 +0100 Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> Guillaume Lelarge a écrit :
>> v4 patch attached.
>>
>
> v5 patch attached.
>

Thanks Guillaume.

Maybe this is nit-picking, but i see that you have to rmdir() an existing
empty tablespace directory to use copydir() afterwards. Maybe we can teach
copydir() to error out when trying to mkdir() an existing directory only
when forced by the caller? I see copydir() used at four places, so the
impact of this change would be minimal.

--  Thanks
                   Bernd


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Greg Smith
Дата:
Сообщение: Re: [WIP] In-place upgrade
Следующее
От: "Robert Haas"
Дата:
Сообщение: Re: [WIP] In-place upgrade