Re: add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext

Поиск
Список
Период
Сортировка
Искать
От
Daniel Gustafsson
Тема
Re: add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext
Дата
Msg-id
BA5F8D50-2E9C-4DC0-AF0F-2C5CCBE41731@yesql.se
Ответ на
Список
Дерево обсуждения
add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext jian he <jian.universality@gmail.com>
Re: add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext Daniel Gustafsson <daniel@yesql.se>
> On 3 Sep 2023, at 05:16, jian he  wrote:

> In src/backend/executor/nodeAgg.c
> 817: advance_aggregates(AggState *aggstate)
> 
> Do we need to add "(void)" before ExecEvalExprSwitchContext?

I don't think we need to, but we could since we are in fact discardnig the
return value.  Did you get a compiler warning on unchecked return, and if so
with which flags?

--
Daniel Gustafsson



В списке pgsql-hackers по дате отправления
От: Daniel Gustafsson
Дата:
От: Hayato Kuroda (Fujitsu)
Дата:
FAQ