Re: pg_receivexlog --status-interval add fsync feedback

Поиск
Список
Период
Сортировка
От
Тема Re: pg_receivexlog --status-interval add fsync feedback
Дата
Msg-id A9C510524E235E44AE909CD4027AE196BF7C70D193@MBX-MSG-SV03.msg.nttdata.co.jp
обсуждение исходный текст
Ответ на Re: pg_receivexlog --status-interval add fsync feedback  (Sawada Masahiko <sawada.mshk@gmail.com>)
Ответы Re: pg_receivexlog --status-interval add fsync feedback  (Sawada Masahiko <sawada.mshk@gmail.com>)
Список pgsql-hackers
Thanks for the review!

> One question is why reply_fsync is defined as volatile variable?
> Sorry I could not understand reason of that.

It was affected to time_to_abort -- since it is unnecessary, it deletes. 

> Currently patch modifies argument of some function (e.g., Handle
> CopyStream, Process LogDate Msg), and add the similar code to each
> function.
> I don't think it is good approach.
> For example, I think that we should gather these code into one function.

Feedback was judged immediately after each fsync until now. 
I revised it in reference to walreceiver.
Feedback of fsync is judged together with the judgment of --status-interval.
Thereby, the specification to an argument became minimum. 

Regards,

--
Furuya Osamu

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Asif Naeem
Дата:
Сообщение: Re: [BUGS] BUG #9652: inet types don't support min/max
Следующее
От: Rahila Syed
Дата:
Сообщение: Fwd: [REVIEW] Re: Compression of full-page-writes