Re: Cluster::restart dumping logs when stop fails

> On 6 Apr 2024, at 23:44, Andres Freund <andres@anarazel.de> wrote:

> It might be useful to print a few lines, but the whole log files can be
> several megabytes worth of output.

The non-context aware fix would be to just print the last 1024 (or something)
bytes from the logfile:

diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
index 54e1008ae5..53d4751ffc 100644
--- a/src/test/perl/PostgreSQL/Test/Cluster.pm
+++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -951,8 +951,8 @@ sub start

     if ($ret != 0)
     {
-        print "# pg_ctl start failed; logfile:\n";
-        print PostgreSQL::Test::Utils::slurp_file($self->logfile);
+        print "# pg_ctl start failed; logfile excerpt:\n";
+        print substr PostgreSQL::Test::Utils::slurp_file($self->logfile), -1024;

         # pg_ctl could have timed out, so check to see if there's a pid file;
         # otherwise our END block will fail to shut down the new postmaster.


Would that be a reasonable fix?

--
Daniel Gustafsson