Table AM callback table_complete_speculative()'s succeeded argumentis reversed

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Table AM callback table_complete_speculative()'s succeeded argumentis reversed
Дата
Msg-id 97673451-339f-b21e-a781-998d06b1067c@iki.fi
обсуждение исходный текст
Ответы Re: Table AM callback table_complete_speculative()'s succeeded argument is reversed
Список pgsql-hackers
The 'succeeded' argument seems backwards here:

> static void
> heapam_tuple_complete_speculative(Relation relation, TupleTableSlot *slot,
>                                   uint32 spekToken, bool succeeded)
> {
>     bool        shouldFree = true;
>     HeapTuple    tuple = ExecFetchSlotHeapTuple(slot, true, &shouldFree);
> 
>     /* adjust the tuple's state accordingly */
>     if (!succeeded)
>         heap_finish_speculative(relation, &slot->tts_tid);
>     else
>         heap_abort_speculative(relation, &slot->tts_tid);
> 
>     if (shouldFree)
>         pfree(tuple);
> }

According to the comments, if "succeeded = true", the insertion is 
completed, and otherwise it's killed. It works, because the only caller 
is also passing the argument wrong.

Barring objections, I'll push the attached patch to fix that.

- Heikki

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Tab completion for CREATE TYPE
Следующее
От: "Ideriha, Takeshi"
Дата:
Сообщение: RE: Copy data to DSA area