Re: some pg_dump query code simplification
От
Peter Eisentraut
Тема
Re: some pg_dump query code simplification
Дата
Msg-id
9700dff7-f05a-9129-09ab-a9be54903d6b@2ndquadrant.com
Ответ на
Re: some pg_dump query code simplification (Tom Lane)
Список
Дерево обсуждения
some pg_dump query code simplification Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: some pg_dump query code simplification Tom Lane <tgl@sss.pgh.pa.us>
Re: some pg_dump query code simplification Stephen Frost <sfrost@snowman.net>
Re: some pg_dump query code simplification Tom Lane <tgl@sss.pgh.pa.us>
Re: some pg_dump query code simplification Stephen Frost <sfrost@snowman.net>
Re: some pg_dump query code simplification Tom Lane <tgl@sss.pgh.pa.us>
Re: some pg_dump query code simplification Stephen Frost <sfrost@snowman.net>
Re: some pg_dump query code simplification Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: some pg_dump query code simplification Stephen Frost <sfrost@snowman.net>
Re: some pg_dump query code simplification Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: some pg_dump query code simplification Stephen Frost <sfrost@snowman.net>
Re: some pg_dump query code simplification Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: some pg_dump query code simplification Tom Lane <tgl@sss.pgh.pa.us>
On 28/08/2018 23:43, Tom Lane wrote: > I think I had this discussion already with somebody, but ... I do not > like this style at all: > > tbinfo->attidentity[j] = (i_attidentity >= 0 ? *(PQgetvalue(res, j, i_attidentity)) : '\0'); OK, updated patch attached. If the updated style is acceptable, I'll start running more extensive tests against the older branches. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата: