Re: Wrap access to Oid in HeapTupleHeader

Manfred Koizar <mkoi-pg@aon.at> writes:
> it indroduces two
> pre-conditions for accessing the oid:
> .  the relation has oids
> .  the heap tuple header is already formatted, i.e. t_hoff is valid

I think the latter test is unnecessary and potentially dangerous;
it could break code that tries to access OID in a
not-yet-completely-built header.  The test that insists t_hoff is valid
before one can *set* OID is even more likely to cause trouble.
I do not see the point of this in any case.

            regards, tom lane