Re: Replacing TAP test planning with done_testing()

Поиск
Список
Период
Сортировка
От Dagfinn Ilmari Mannsåker
Тема Re: Replacing TAP test planning with done_testing()
Дата
Msg-id 87bkzgyuqn.fsf@wibble.ilmari.org
обсуждение исходный текст
Ответ на Replacing TAP test planning with done_testing()  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: Replacing TAP test planning with done_testing()  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:

> Whether or not to explicitly plan the number of TAP tests per suite has been
> discussed a number of times on this list, often as a side-note in an unrelated
> thread which adds/modifies a test.  The concensus has so far weighed towards
> not doing manual bookkeeping of test plans but to let Test::More deal with it.
> So far, no concrete patch to make that happen has been presented though.
>
> The attached patch removes all Test::More planning and instead ensures that all
> tests conclude with a done_testing() call.  While there, I also removed a few
> exit(0) calls from individual tests making them more consistent.
>
> Thoughts?

LGTM, +1.

I have grepped the patched code and can verify that there are no
occurrences of `tests => N` (with or without quotes around `tests`) left
in any test scripts, and `make check-world` passes.

I'm especially pleased by the removal of the big chunks of test count
calculating code in the pg_dump tests.

- ilmari



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dong Wook Lee
Дата:
Сообщение: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Следующее
От: Dong Wook Lee
Дата:
Сообщение: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)