Re: pgsql: Remove obsolete executor cleanup code

Amit Langote <amitlan@postgresql.org> writes:
> After these modifications, the ExecEnd*() routines for ValuesScan,
> NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> commit removes them.

This seems like quite a bad idea.  From a documentation standpoint
alone, it would be far better for these functions to exist but be
empty.

            regards, tom lane