Re: Add version and data directory to initdb output

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Add version and data directory to initdb output
Дата
Msg-id 7C749AC3-176A-4622-98EA-D5A852A078D9@yesql.se
обсуждение исходный текст
Ответ на Add version and data directory to initdb output  ("David G. Johnston" <david.g.johnston@gmail.com>)
Ответы Re: Add version and data directory to initdb output  ("David G. Johnston" <david.g.johnston@gmail.com>)
Список pgsql-hackers
> On 16 Apr 2022, at 01:50, David G. Johnston <david.g.johnston@gmail.com> wrote:

> initdb is already pretty chatty, and the version of the cluster being installed seems useful to include as well.

That seems quite reasonable.

> The data directory is probably less so - though I am thinking that the absolute path would be useful to report,
especiallywhen a relative path is specified (I didn't figure that part out yet, figured I'd get the idea approved
beforeworking out how to make it happen). 

I'm less convinced that it will be worth the additional code to make it
portable across *nix/Windows etc.

> Moving "Success" to that "summary output" line and leaving the optional shell command line just be the shell command
madesense to me. 

Looking at the output, couldn't it alternatively be printed grouped with the
other info on the cluster, ie the final three rows in the example below:

  ./bin/initdb -D data
  The files belonging to this database system will be owned by user "<username>".
  This user must also own the server process.

  The database cluster will be initialized with locale "en_US.UTF-8".
  The default database encoding has accordingly been set to "UTF8".
  The default text search configuration will be set to "english".

How about 'The database cluster will be initialized with version "14.2".' added
there, which then can keep the "Success" line in place in case existing scripts
are triggering on that line?

--
Daniel Gustafsson        https://vmware.com/




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Stabilizing the test_decoding checks, take N