Re: Obsolete comment in tidpath.c

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Obsolete comment in tidpath.c
Дата
Msg-id 7993.1444168903@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Obsolete comment in tidpath.c  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Obsolete comment in tidpath.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Oct 5, 2015 at 3:05 AM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> I think "best_inner_indexscan()" in the following comment in tidpath.c
>> is obsolete.
>> 
>> * There is currently no special support for joins involving CTID; in
>> * particular nothing corresponding to best_inner_indexscan().  Since it's
>> * not very useful to store TIDs of one table in another table, there
>> * doesn't seem to be enough use-case to justify adding a lot of code
>> * for that.
>> 
>> How about s/best_inner_indexscan()/parameterized scans/?

> I'm not sure that's altogether clear.

Probably consider_index_join_clauses() is the closest current equivalent.
However, it may not be such a great idea to have this comment referencing
a static function in another file, as it wouldn't occur to people to look
here when rewriting indxpath.c.  (Ahem.)

Perhaps "in particular, no ability to produce parameterized paths here".
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: check fails on Fedora 23
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pg_ctl/pg_rewind tests vs. slow AIX buildfarm members