On 11 January 2013 15:57, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>>> I've moved this to the next CF. I'm planning to review this one first.
>>
>>> Thank you.
>
>> Just reviewing the patch now, making more sense with comments added.
> Making more sense, but not yet making complete sense.
> I'd like you to revisit the patch comments since some of them are completely unreadable.
I have modified most of the comments in code.
The changes in attached patch are as below:
1. Introduced Encoded WAL Tuple (EWT) to refer to delta encoded tuple for update operation.
It can rename to one of below:
a. WAL Encoded Tuple (WET)
b. Delta Encoded WAL Tuple (DEWT)
c. Delta WAL Encoded Tuple (DWET)
d. any others?
2. I have kept the wording related to compression in modified docs, but i have tried to copy parts completely.
IMO this is required as there are some changes w.r.t LZ compression like for New Data.
3. There is small coding change as it has been overwritten by one of my previous patch patches.
Calculation of approximate length for encoded wal tuple.
Previous Patch:
if ((bp + (2 * new_tup_bitmaplen)) - bstart >= result_max)
New Patch:
if ((bp + (2 + new_tup_bitmaplen)) - bstart >= result_max)
The previous patch calculation was valid if we could have exactly used LZ format.
With Regards,
Amit Kapila.