Re: [CF2016-9] Allow spaces in working path on tap-tests
| От | Tom Lane |
|---|---|
| Тема | Re: [CF2016-9] Allow spaces in working path on tap-tests |
| Дата | |
| Msg-id | 6906.1468097407@sss.pgh.pa.us обсуждение |
| Ответ на | Re: [CF2016-9] Allow spaces in working path on tap-tests (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>) |
| Ответы |
Re: [CF2016-9] Allow spaces in working path on tap-tests
|
| Список | pgsql-hackers |
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> At Tue, 5 Jul 2016 13:44:08 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in
<CAB7nPqSt2W30tE12eRq7KGB_FPcBpXDX2Zh8XeH2QHFY9Vfb8Q@mail.gmail.com>
>> Attached is the patch I have in mind. After more investigation zic.exe
>> is indeed broken, $target can be a full path, and if it contains a
>> space things blow up. The commands of vcregress upgradecheck need a
>> cleanup as well. I have merged both patches together and the part for
>> src/tools/msvc needs a backpatch. Separating both things is trivial
>> anyway as the MSVC and the TAP stuff are on two completely separate
>> paths.
> Agreed. Grep'ing "system" in the source tree, I see no more place
> where needs the same fix.
This seemed like a bug fix to me, so I went ahead and pushed it. I don't
have any ability to test the Windows parts, so it's possible I missed
something in the back-patching; please review.
regards, tom lane
В списке pgsql-hackers по дате отправления: