On 8/29/22 8:56 AM, Amit Langote wrote:
> On Sat, Aug 27, 2022 at 5:11 AM Nikita Glukhov <n.gluhov@postgrespro.ru> wrote:
> I am not sure if it's OK to eval_const_expressions() on a Query
> sub-expression during parse-analysis. IIUC, it is only correct to
> apply it to after the rewriting phase.
>
>> Maybe it would be better to simply remove DEFAULT ON EMPTY.
>
> So +1 to this for now.
+1, if this simplifies the patch and makes it acceptable for v15
>> It is possible to easily split this patch into several subpatches,
>> I will do it if needed.
>
> That would be nice indeed.
With RMT hat on, the RMT has its weekly meetings on Tuesdays. Based on
the timing of the Beta 4 commit freeze[1] and how both
including/reverting are nontrivial operations (e.g. we should ensure
we're confident in both and that they pass through the buildfarm), we
are going to have to make a decision on how to proceed at the next meeting.
Can folks please chime in on what they think of the current patchset and
if this is acceptable for v15?
Thanks,
Jonathan
[1]
https://www.postgresql.org/message-id/9d251aec-cea2-bc1a-5ed8-46ef0bcf6c69@postgresql.org