Re: pg9.6 segfault using simple query (related to use fk for join estimates)

On 29/04/2016 18:05, Tom Lane wrote:
> Julien Rouhaud <julien.rouhaud@dalibo.com> writes:
>> The segfault is caused by quals_match_foreign_key() calling get_leftop()
>> and get_rightop() on a ScalarArrayOpExpr node.
>
>> Reordering the common fields of OpExpr and ScalarArrayOpExpr at the
>> beginning of the struct so the get_*op() work with either (as in
>> attached patch) fixes the issue.
>
>> I'm not sure that assuming this compatibility is the right way to fix
>> this though.
>
> It certainly isn't.
>

Agreed. New attached patch handles explicitly each node tag.

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org