On 2016/04/04 20:35, Michael Paquier wrote:
> On Mon, Apr 4, 2016 at 7:49 PM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> Here is a patch to fix this issue. As proposed by Michael, I modified
>> execute_dml_stmt so that it uses PQsendQueryParams, not PQexecParams. Any
>> comments are welcome.
> + * This is based on pqSocketCheck.
> + */
> + bool
> + CheckSocket(PGconn *conn)
> + {
> + int ret;
> +
> + Assert(conn != NULL);
> Instead of copying again pqSocketQuery, which is as well copied in
> libpqwalreceiver.c, wouldn't it be better to use WaitLatchOrSocket
> with the socket returned by PQsocket?
Will check. Thanks for the comment!
Best regards,
Etsuro Fujita