On 2016/01/07 21:45, Etsuro Fujita wrote:
> On 2016/01/06 18:58, Rushabh Lathia wrote:
>> .) Documentation for the new API is missing (fdw-callbacks).
> Will add the docs.
I added docs for new FDW APIs.
Other changes:
* Rename relation_has_row_level_triggers to relation_has_row_triggers
shortly, and move it to rewriteHandler.c. I'm not sure rewriteHandler.c
is a good place for that, though.
* Revise code, including a helper function get_result_result, whcih I
implemented using a modified version of store_returning_result in the
previous patch, but on second thought, I think that that is a bit too
invasive. So, I re-implemented that function directly using
make_tuple_from_result_row.
* Add more comments.
* Add more regression tests.
Attached is an updated version of the patch. Comments are wellcome!
(If the fix [1] is okay, I'd like to update this patch on top of the
patch in [1].)
Best regards,
Etsuro Fujita
[1] http://www.postgresql.org/message-id/568F4430.6060805@lab.ntt.co.jp