ATT_FOREIGN_TABLE and ATWrongRelkindError()

Поиск
Список
Период
Сортировка
От Amit Langote
Тема ATT_FOREIGN_TABLE and ATWrongRelkindError()
Дата
Msg-id 562727CC.5000100@lab.ntt.co.jp
обсуждение исходный текст
Ответы Re: ATT_FOREIGN_TABLE and ATWrongRelkindError()  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Hi,

This may just be nitpicking but I noticed that ATWrongRelkindError() could
emit a better message in case of such errors during ALTER COLUMN DEFAULT
and  ALTER COLUMN SET STORAGE than "%s is of the wrong type" which is what
it would emit now. Just need to add a couple of cases to the switch there:

+ case ATT_TABLE | ATT_VIEW | ATT_FOREIGN_TABLE:
+     msg = _("\"%s\" is not a table, view or foreign table");
+     break;

+ case ATT_TABLE | ATT_MATVIEW | ATT_FOREIGN_TABLE:
+     msg = _("\"%s\" is not a table, materialized view, or foreign table");
+     break;

Attached adds those.

Thanks,
Amit

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fabien COELHO
Дата:
Сообщение: Re: checkpointer continuous flushing
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: [PATCH v3] GSSAPI encryption support