Re: TABLESAMPLE patch

On 06/04/15 11:02, Simon Riggs wrote:
> On 2 April 2015 at 17:36, Petr Jelinek <petr@2ndquadrant.com> wrote:
>
>> so here is version 11.
>
> Looks great.
>
> Comment on docs:
>
> The SELECT docs refer only to SYSTEM and BERNOULLI. It doesn't mention
> that if other methods are available they could be used also. The
> phrasing was "sampling method can be one of <list>."
>

Will reword.

> Are we ready for a final detailed review and commit?
>

I plan to send v12 in the evening with some additional changes that came 
up from Amit's comments + some improvements to error reporting. I think 
it will be ready then.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services