Re: PATCH: numeric timestamp in log_line_prefix

On 22.3.2015 08:14, David Rowley wrote:
> Hi Tomas,
> 
> I just had a quick glance at this.
> Is there a reason you didn't include code to support the space padding
> for the new log_line_prefixes?
> The others support  %<padding><char> in the prefix, to allow left or
> right alignment of the item.

Didn't realize that, will fix in the next version.

> 
> Also, what's the reason for timestamp_str? Could you not just use 
> appendStringInfo() and skip the temporary buffer?

Yeah, that's probably a good idea too.

> 
> Regards
> 
> David Rowley 



-- 
Tomas Vondra                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services