Re: [RFC] LSN Map

Il 08/01/15 20:18, Jim Nasby ha scritto:
> On 1/7/15, 3:50 AM, Marco Nenciarini wrote:
>> The current implementation tracks only heap LSN. It currently does not
>> track any kind of indexes, but this can be easily added later.
>
> Would it make sense to do this at a buffer level, instead of at the heap
> level? That means it would handle both heap and indexes.
>  I don't know if LSN is visible that far down though.

Where exactly you are thinking to handle it?

>
> Also, this pattern is repeated several times; it would be good to put it
> in it's own function:
> +         lsnmap_pin(reln, blkno, &lmbuffer);
> +         lsnmap_set(reln, blkno, lmbuffer, lsn);
> +         ReleaseBuffer(lmbuffer);

Right.

Regards,
Marco

--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco.nenciarini@2ndQuadrant.it | www.2ndQuadrant.it