Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes

Поиск
Список
Период
Сортировка
От Boszormenyi Zoltan
Тема Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes
Дата
Msg-id 52A1CAB6.9020600@cybertec.at
обсуждение исходный текст
Ответ на Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes  (Boszormenyi Zoltan <zb@cybertec.at>)
Ответы Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes  (Antonin Houska <antonin.houska@gmail.com>)
Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
2013-12-04 14:51 keltezéssel, Boszormenyi Zoltan írta:
> 2013-12-03 16:48 keltezéssel, Antonin Houska írta:
>
>> Tests - 23.patch
>> ----------------
>>
>> src/interfaces/ecpg/test/sql/cursorsubxact.pgc
>>
>>
>>          /*
>>           * Test the implicit RELEASE SAVEPOINT if a SAVEPOINT
>>           * is used with an already existing name.
>>           */
>>
>> Shouldn't it be "... if a CURSOR is used with an already existing
>> name?". Or just "... implicit RELEASE SAVEPOINT after an error"?
>> I'd also appreciate a comment where exactly the savepoint is
>> (implicitly) released.
>
> I have already answered this in my previous answer.

And I was wrong in that. The comments in the test were rearranged
a little and the fact in the above comment is now actually tested.

Some harmless unused variables were also removed and an
uninitialized variable usage was fixed. Because of these and the above
changes a lot of patches need to be rebased.

All patches are attached again for completeness.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fabrízio de Royes Mello
Дата:
Сообщение: Re: dblink performance regression
Следующее
От: Boszormenyi Zoltan
Дата:
Сообщение: Re: ECPG FETCH readahead, was: Re: ECPG fixes