> On 7 May 2024, at 01:31, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, May 03, 2024 at 10:39:15AM +0200, Daniel Gustafsson wrote:
>> They are no-ops when linking against v18, but writing an extension which
>> targets all supported versions of postgres along with their respective
>> supported OpenSSL versions make them still required, or am I missing something?
>
> Yeah, that depends on how much version you expect your application to
> work on. Still it seems to me that there's value in mentioning that
> if your application does not care about anything older than OpenSSL
> 1.1.0, like PG 18 assuming that this patch is merged, then these calls
> are pointless for HEAD. The routine definitions would be around only
> for the .so compatibility.
Fair enough. I've taken a stab at documenting that the functions are
deprecated, while at the same time documenting when and how they can be used
(and be useful). The attached also removes one additional comment in the
testcode which is now obsolete (since removing 1.0.1 support really), and fixes
the spurious whitespace you detected upthread.
--
Daniel Gustafsson