Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the sametransaction
От | Peter Eisentraut |
---|---|
Тема | Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the sametransaction |
Дата | |
Msg-id | 4a3d7e55-1f57-f501-d5ac-2adff9256878@2ndquadrant.com обсуждение исходный текст |
Ответ на | Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction (Arseny Sher <a.sher@postgrespro.ru>) |
Ответы |
Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction
|
Список | pgsql-hackers |
On 9/14/17 15:47, Arseny Sher wrote: > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: > >> On 9/13/17 07:00, Arseny Sher wrote: >>> On the other hand, forbidding to execute disable sub and drop sub in one >>> transaction makes it impossible e.g. to drop subscription in trigger >> >> Disabling a subscription before dropping it isn't very useful, is it? >> So I'm not sure this is an important use case we need to optimize. We >> just need to prevent it from hanging. > > Not quite so. Currently it is forbidded to set subscription's slot to > NONE on enabled sub, and the only way to drop sub without touching the > slot is to run ALTER SUBSCRIPTION SET (SLOT_NAME = NONE) beforehand. > Practically this means that we have to go through disable sub -> alter > sub -> drop sub pipeline if we want to left the slot alone or just would > like to drop sub in transaction block -- with replication slot set the > latter is impossible. OK, good point. Here is a simple patch that fixes this, based on my original proposal point #4. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
В списке pgsql-hackers по дате отправления: