On 06/22/2011 08:35 AM, Andrew Dunstan wrote:
>
>
> On 06/22/2011 02:03 AM, David Christensen wrote:
>>> # Avoid bug that converts 'x =- 1' to 'x = -1'
>>> $source =~ s!=- !-= !g;
>>
>> I haven't looked at the shell script this replaces, but is that the
>> correct substitution pattern? (BTW, I'm not seeing the token =-
>> anywhere except in the Makefile, which wouldn't be run against, no?
>> Am I missing something?)
>>
>>
>
>
> It's exactly what the current script does. The reason you don't see
> this anywhere is that previous pgindent runs have removed it. We don't
> undo the transformation. But maybe we should just get rid of it.
>
>
Further research shows that C89 explicitly dropped support for the old
K&R "=-" operator, so we probably *should* remove this in case it
introduces an unintended bug.
cheers
andrew