Tom Lane wrote:
"Kevin Grittner" writes:
>> It's obviously too low level to be the right place to check
>> whether we're in serializable mode and take out locks, but if I
>> look at the callers (like IndexNext or TidNext) which use a valid
>> buffer in a call to ExecStoreTuple, should I be catching all the
>> tuples read from the heap?
> It doesn't really matter, because any patch putting such functionality
> into ExecStoreTuple would be rejected. It's an utterly inappropriate
> place.
Which is what I said.
> I think you'd probably be best off to put the hook in SeqNext,
> IndexNext, etc. Sometimes multiple call sites are the cleanest
> solution.
Which is what I said.
I'm glad we agree.
From your response, I assume that there aren't any end runs to cover.
Thanks,
-Kevin