Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> In looking at this patch, it changes mac.c from:
>>
>> 8513 mac.c
>> 184323 mac.c.new
Yipes.
>> This seems like a major size increase. Is it worth it to get
>> card manufacturers?
> Given that our list is old, and the new list is large, does anyone
> really want this feature. It allows the lookup of an ethernet card
> manufacturer based on the ethernet MAC address.
Seems like hardwiring the lookup table in the server code is
fundamentally wrongheaded anyway. It should have been designed as
(wait for it...) a database table lookup.
I'd suggest maybe this feature should be offered as a contrib item
containing a database table dump and a simple lookup function
coded in SQL. Lots easier to maintain, and it doesn't bloat the
backend for people who don't need it.
regards, tom lane