[PATCH] minor reloption regression tests improvement

Поиск
Список
Период
Сортировка
От Nikolay Shaplov
Тема [PATCH] minor reloption regression tests improvement
Дата
Msg-id 4563991.km65PDbjlG@thinkpad-pgpro
обсуждение исходный текст
Ответы Re: [PATCH] minor reloption regression tests improvement  (Greg Stark <stark@mit.edu>)
Список pgsql-hackers
I'd like to suggest a patch for reloption regression tests.

This patch tests case, that can be rarely met in actual life: when reloptions 
have some illegal option set (as a result of malfunction or extension 
downgrade or something), and user tries to remove this option by using RESET.
Current postgres behaviour is to actually remove this option.

Like:

UPDATE pg_class  SET reloptions = '{illegal_option=4}' 
   WHERE oid = 'reloptions_test'::regclass;

ALTER TABLE reloptions_test RESET (illegal_option);

Why this should be tested:
1. It is what postgres actually do now.
2. This behaviour is reasonable. DB User can fix problem without updating 
pg_class, having rights to change his own table.
3. Better to get test alarm, if this behavior is accidentally changed.  

-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Christoph Berg
Дата:
Сообщение: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Следующее
От: Dilip Kumar
Дата:
Сообщение: Assertion failure in WaitForWALToBecomeAvailable state machine