Re: ALTER TABLE RENAME fix
От | Hiroshi Inoue |
---|---|
Тема | Re: ALTER TABLE RENAME fix |
Дата | |
Msg-id | 3BF05FB3.91C9EE84@tpf.co.jp обсуждение исходный текст |
Ответ на | Re: ALTER TABLE RENAME fix (Bruce Momjian <pgman@candle.pha.pa.us>) |
Ответы |
Re: ALTER TABLE RENAME fix
|
Список | pgsql-patches |
Bruce Momjian wrote: > > > On 12 Nov 2001 at 18:28 (+0100), Peter Eisentraut wrote: > > | Brent Verner writes: > > | > > | > These patches fix the problem where an > > | > > > | > ALTER TABLE <table> RENAME <oldcolumn> TO <newcolumn> > > | > > > | > did not update the RI_ triggers if the oldcolumn was referenced in > > | > a RI constraint. > > | > > | Instead of trying to fix this, how about making the RI triggers not use > > | the column names in the first place. (Instead they should use the oid of > > | the table and the attnums.) > > > > I agree with you. Two things led me toward the current approach > > (modifying tgargs) > > 1) it would require fewer changes to get correct behavior, which > > was important as late in beta as I started and > > 2) I had /some/ idea of how to get it done ;-) > > > > I'll begin to look at what would be required to do it the right > > way for 7.3. > > Added to TODO: > > * Make triggers refer to columns by oid, not name What OIDs could we use to point columns ? Is it really a good idea to use IDs or numbers in the first place ? We know now reference by IDs aren't necessarily good, don't we ? It's not preferable to optimize only *rename*. IMHO this should be considered as a part of total object-dependency mechanism. regards, Hiroshi Inoue
В списке pgsql-patches по дате отправления: