Re: Testing the async-commit patch
| От | Tom Lane |
|---|---|
| Тема | Re: Testing the async-commit patch |
| Дата | |
| Msg-id | 3812.1187108964@sss.pgh.pa.us обсуждение |
| Ответ на | Re: Testing the async-commit patch ("Simon Riggs" <simon@2ndquadrant.com>) |
| Ответы |
Re: Testing the async-commit patch
Re: Testing the async-commit patch |
| Список | pgsql-hackers |
"Simon Riggs" <simon@2ndquadrant.com> writes:
> On Tue, 2007-08-14 at 12:09 -0400, Tom Lane wrote:
>> heapam.c lines 1843-1852 presume previous xmax can be hinted
>> immediately, ditto lines 2167-2176, ditto lines 2716-2725.
>> I think probably we should just remove those lines --- they are only
>> trying to save work for future tqual.c calls.
> I'll check those out later tonight.
[ looks closer ] Actually, we can't just dike out those code sections,
because the immediately following code assumes that XMAX_INVALID is
correct. So I guess we need to export HeapTupleSetHintBits from tqual.c
and do the full pushup in these places.
regards, tom lane
В списке pgsql-hackers по дате отправления: