Re: websearch_to_tsquery() returns queries that don't match to_tsvector()

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Дата
Msg-id 3712828.1619978696@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: websearch_to_tsquery() returns queries that don't match to_tsvector()  (Alexander Korotkov <aekorotkov@gmail.com>)
Ответы Re: websearch_to_tsquery() returns queries that don't match to_tsvector()  (Alexander Korotkov <aekorotkov@gmail.com>)
Список pgsql-hackers
Alexander Korotkov <aekorotkov@gmail.com> writes:
> Ooops, I've included this by oversight.  The next revision is attached.
> Anything besides that?

Some quick eyeball review:

+                    /* Everything is quotes is processed as a single token */

Should read "Everything in quotes ..."

-                    /* or else gettoken_tsvector() will raise an error */
+                    /* or else ƒtsvector() will raise an error */

Looks like an unintentional change?

@@ -846,7 +812,6 @@ parse_tsquery(char *buf,
     state.buffer = buf;
     state.buf = buf;
     state.count = 0;
-    state.in_quotes = false;
     state.state = WAITFIRSTOPERAND;
     state.polstr = NIL;

This change seems wrong/unsafe too.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Следующее
От: Zhihong Yu
Дата:
Сообщение: Re: websearch_to_tsquery() returns queries that don't match to_tsvector()