Re: [PATCH] Add min() and max() aggregate functions for xid8

Поиск
Список
Период
Сортировка
От Ken Kato
Тема Re: [PATCH] Add min() and max() aggregate functions for xid8
Дата
Msg-id 366448a09d8c2265f5f85d4363e0512c@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: [PATCH] Add min() and max() aggregate functions for xid8  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Ответы Re: [PATCH] Add min() and max() aggregate functions for xid8  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Список pgsql-hackers
On 2022-02-08 15:34, Fujii Masao wrote:
> Thanks for updating the patch! It basically looks good to me. I
> applied the following small changes to the patch. Updated version of
> the patch attached. Could you review this version?

Thank you for the patch!

It looks good to me!

I'm not sure how strict coding conventions are, but the following line 
is over 80 characters.
+insert into xid8_t1 values ('0'), ('010'), ('42'), 
('0xffffffffffffffff'), ('-1');
Therefore, I made a patch which removed ('010') just to fit in 80 
characters.


Best wishes,

-- 
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "kuroda.hayato@fujitsu.com"
Дата:
Сообщение: RE: Logical replication timeout problem
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: [BUG]Update Toast data failure in logical replication