Re: Convert *GetDatum() and DatumGet*() macros to inline functions

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Convert *GetDatum() and DatumGet*() macros to inline functions
Дата
Msg-id 3612876.1661868800@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Convert *GetDatum() and DatumGet*() macros to inline functions  (Aleksander Alekseev <aleksander@timescale.com>)
Ответы Re: Convert *GetDatum() and DatumGet*() macros to inline functions  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Aleksander Alekseev <aleksander@timescale.com> writes:
> Just to clarify, a break in this case is going to be the fact that we
> are adding new functions, although inlined, correct? Or maybe
> something else? I'm sorry this is the first time I encounter the
> question of ABI compatibility in the context of Postgres, so I would
> appreciate it if you could elaborate a bit.

After absorbing a bit more caffeine, I suppose that replacing a
macro with a "static inline" function would not be an ABI break,
at least not with most modern compilers, because the code should
end up the same.  I'd still vote against back-patching though.
I don't think the risk-reward ratio is good, especially not for
the pre-C99 branches which don't necessarily have "inline".

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Aleksander Alekseev
Дата:
Сообщение: Re: Convert *GetDatum() and DatumGet*() macros to inline functions
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Convert *GetDatum() and DatumGet*() macros to inline functions