Re: Patch: Remove gcc dependency in definition of inline functions

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Patch: Remove gcc dependency in definition of inline functions
Дата
Msg-id 3468.1260976230@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Patch: Remove gcc dependency in definition of inline functions  (Marko Kreen <markokr@gmail.com>)
Ответы Re: Patch: Remove gcc dependency in definition of inline functions  (Marko Kreen <markokr@gmail.com>)
PostgreSQL project policy compendium  (Kurt Harriman <harriman@acm.org>)
Список pgsql-hackers
Marko Kreen <markokr@gmail.com> writes:
> Hypothetical old, crappy compilers would still work, only AC_C_INLINE
> would turn "static inline" into plain "static", so hypothetically
> they would get some warnings about unused functions.

> As this is all hypothetical, I don't see why that should stop us
> cleaning our code?

There's nothing "hypothetical" about it --- I still regularly check
that the code builds on an old HP compiler that doesn't have inline.

I remind you that the project policy is to not require any compiler
features not found in C89.  If you can exploit inline on more compilers
than now, fine, but assuming that everything has got it is not OK.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Fast or immediate shutdown
Следующее
От: "Kevin Grittner"
Дата:
Сообщение: Re: idea - new aggregates median, listagg