Re: PL/Perl Does not Like vstrings

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: PL/Perl Does not Like vstrings
Дата
Msg-id 3447.1325786954@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: PL/Perl Does not Like vstrings  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: PL/Perl Does not Like vstrings  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> The fix that has been applied, as Tom suggested, is at the point where 
> we call SvPVutf8(), so that's not just for elog().

That patch looks good, but do we want to look into the other point about
error recovery?  The real bottom line here is that when SvPVutf8 threw a
croak(), we didn't recover sanely at all --- in fact, it was almost
impossible to tell what had happened even in gdb, until I installed
perl debugging symbols and single-stepped through things.  I would have
hoped that we'd at least see the croak message.  This seems a bit
nervous-making, as plperl sure calls a lot of stuff that in principle
could croak.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: PL/Perl Does not Like vstrings
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: PL/Perl Does not Like vstrings