Hello
> I have reworked that part, adding more comments about the use of GUC
> parameters when establishing the connection to the primary for a WAL
> receiver. And also I have added an extra comment to walreceiver.c
> about the use of GUcs in general, to avoid this stuff again in the
> future. There were some extra nits with the format of
> postgresql.conf.sample.
Thank you! I just noticed that you removed my proposed change to this condition in RequestXLogStreaming
- if (slotname != NULL)
+ if (slotname != NULL && slotname[0] != '\0')
We need this change to set is_temp_slot properly. PrimarySlotName GUC can usually be an empty string, so just "slotname
!=NULL" is not enough.
I attached patch with this change.
regards, Sergei