Re: Merge Append Patch merged up to 85devel

On Sat, Jul 25, 2009 at 2:26 PM, Greg Stark wrote:
>
> more complex examples would trigger it naturally such as:
>
> select * from partitioned_table where active order by indexed_column
> (with an index on indexed_column where active)
>
> or
>
> select * from partitioned_table where indexed_column between x and y
> order by indexed_column
>

look at the example, i had three OR'ed conditions on col1 wich is
indexed (in the script those where commented but i tried it first) and
i get the same plan than in 8.4

but you're right with "enable_seqscan to off" i get a better plan,
attaching explain analyze in 8.4 and 8.5 (with seqscan to on and off)

>
>> another thing a don't like is those #ifdef FIXME surrounding already
>> existing if, why are those? and if they need to be fixed why there
>> isn't a comment explaining what the fix is or what it should behave?
>
> Yeah, if I knew how to fix them then this patch wouldn't be stuck
> waiting for feedback... :(
>

and what's the problem with those if? as someone says before feel free
to speak slowly and draw pictures ;)

-- 
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157