Re: renumber_oids.pl needs some updates

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: renumber_oids.pl needs some updates
Дата
Msg-id 2eab924a-9667-d287-5e84-a3c54d5f433e@enterprisedb.com
обсуждение исходный текст
Ответ на renumber_oids.pl needs some updates  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: renumber_oids.pl needs some updates  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 20.04.22 22:45, Tom Lane wrote:
> I think the right way to fix #2 is to put the responsibility for
> generating the #define's into genbki.pl, instead of this mistake-prone
> approach of duplicating the OID constants in the source code.
> 
> The attached proposed patch invents a variant macro
> DECLARE_TOAST_WITH_MACRO for the relatively small number of cases
> where we need such OID macros.

This makes sense.

A more elaborate (future) project would be to have genbki.pl generate 
all of IsSharedRelation(), which is the only place these toast-table-OID 
macros are used, AFAICT.




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [RFC] building postgres with meson -v8