Re: PoC Refactor AM analyse API

Поиск
Список
Период
Сортировка
От Denis Smirnov
Тема Re: PoC Refactor AM analyse API
Дата
Msg-id 29A6A06B-7CE8-4460-AA1F-33DB6709F6BD@arenadata.io
обсуждение исходный текст
Ответ на Re: PoC Refactor AM analyse API  (Zhihong Yu <zyu@yugabyte.com>)
Ответы Re: PoC Refactor AM analyse API
Список pgsql-hackers
Hello,  Zhihong.

Thanks for your comments.

1. I am afraid that an equivalence of "floor(val + 0.5)" to "cell(val)" is incorrect: "floor(2.1 + 0.5)" returns 2
while "cell(2.1)" returns 3. We can’t use such replacement, as you have suggested. 

2. >> For compare_rows(), it seems the computation of oa and ob can be delayed to when ba == bb (after the first two if
statements).
I have checked some examples of ASM code generated by different compilers with -O2/O3 flags on https://gcc.godbolt.org
anddidn’t see any big benefit in result CPU instructions. You can check yourself an attached example below. 



Best regards,
Denis Smirnov | Developer
sd@arenadata.io 
Arenadata | Godovikova 9-17, Moscow 129085 Russia


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: Problem with accessing TOAST data in stored procedures
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: a misbehavior of partition row movement (?)