Re: pgsql-server: Add some strings for translation and remove some

dennis@svr1.postgresql.org (Dennis Bjorklund) writes:
> Add some strings for translation and remove some cut'n'paste
> that makes it impossible to translate to other languages.

The way you've done this, the string will be passed through gettext
twice at runtime (once in this routine, once inside errmsg()).  That's
at best a waste of cycles and at worst a wrong answer.  (Though
a match on the translated string isn't likely, it's not impossible.)

You should use gettext_noop() not gettext() to mark these strings as
translatable.

            regards, tom lane